I like how people are under the impression that the only good way to chart the effectiveness of a controller is by seeing if it works for one specific genre of gaming. You kids are so crazy. It's not like controllers are meant to be universal for multiple genres.
So yeah, if fighting games aren't good on a controller, it doesn't mean the controller sucks. It just means it's not good for fighting games. Fighting games aren't the only type of video games out there, stop thinking they are. Besides, people who REALLY love fighters usually buy fight sticks.
Anyway, yeah, Xbox 360 controller or the Gamecube controller are my favorite.
And I'll also be the first to throw out the original Gameboy in terms of handhelds. It was simple, all the buttons were accessible, and I never got hand cramps like I do nowadays on my PSP and DS (the DS with FPS games or games that use both bumpers is torture).