Hacking [NTR] Need pairs of eyes to help me figure out why fixing code warnings causes NTR CFW to not boot

[delete12345]

Currently working off from this git commit for NTR here:

https://github.com/44670/NTR/tree/02a748eac5758971b64548b45e5701be38b329a1

Things I did:

• I worked on the git branch "goodbye_warnings", with the goal of removing all GCC reported C warnings during compilation.
• I do not know how to thoroughly test the builds I did. I do not know exactly what to test for when building NTR with my merged changes.
• I did test, but I only made sure the code is correctly typecasted explicitly, unused variables are either removed or commented away, return statements are correctly returning the right values, or return NULL on weird return statements where it's just returning VOID on functions expecting return values, and other minor fixes to make GCC happy without complaining a single warning/error.
• I could not figure out why removing these warnings cause NTR to fail to boot. This was reported to me by someone who also worked on NTR and was attempting to test their codes with and without the GCC warning spams during compilation. In the end, they went with the NTR git commit without my "goodbye_warnings" merges.
• I have looked into this matter for a while, but I gave up. I wasn't able to pinpoint the cause, and know what or why, and I even had self-doubts that I don't even have proper debugging tools at all to work on the issue. Right now, there is a time gap of more than 1 year.

Why I wanted a set of fresh eyes on my merged changes:

• I'm motivated to try and fix up what I have caused to NTR.
• But because I don't have any clues, I need help to look and determine if any of my C warnings fixes and changes have somehow caused an issue I was not aware of.
• I don't know where to go from and to at this point.

Let me know if there is anything. Or rather, what is it that I can look for, and in what direction, so I can narrow down the scope of finding where the issue is at?

 

[PabloMK7]

Keep in mind that NTR messes a lot with memory and has to do a lot of hacky stuff to inject itself in other processes. So be careful when removing unused variables as they may actually be used. (Try compiling without removing any unused variables)

 

[delete12345]

Keep in mind that NTR messes a lot with memory and has to do a lot of hacky stuff to inject itself in other processes. So be careful when removing unused variables as they may actually be used. (Try compiling without removing any unused variables)

Ohhh, well darn. I removed them before it was merged into the main branch. The removed variables were previously allocated on the stack (as in, they are locally scoped), and they are not marked as static nor volatile.

Maybe there might be something else I didn't knew about. Thanks.