We aren't going to be merging hacks into Canary. It is a staging ground for Nightly. Or, you know, you could wait for a proper fix which will mean we won't need a hack like that?
I know, but the fix though doesn't sound like it's imminent at all. I understand it's a hack, but it's also a temp. fix for a bad bug in a lot of big games that's been in BE for like a year, which is what I'm sure almost all Citra users used and are now accustomed to.
Anyway, we don't have to get into that - I won't win so it's ok. I just hate that I'm stuck on the last BE for all those games until a proper fix is implemented. That or we can get jrwhojan to merge it into any other future unofficial builds, which is why I posted all that.
My conversation with
jroweboy who was very generous with his time on this topic (for posterity):
8:44 PM
] jroweboy: @wes the batching changes were submitted to master but were rejected. They probably won't be in canary
[8:50 PM
] Wes:Thanks for the update. It really sucks that the batching "temp solution" is being rejected. Without it, major games are too annoying to play.
[8:50 PM
] jroweboy: The reason why bleeding edge was taken offline is it's possible that the changes made for canary could push a bad build for bleeding edge, one without the updater which is way worse than a few weeks with no updates
[8:50 PM
] Wes: ok, i get it
[8:50 PM
] jroweboy: Yeah I'm aware. The problem with the batching fix is no one will research what's actually the reason it's broken. We know it's broken, but by all means, it shouldn't be
[8:51 PM
] jroweboy: So adding a hack like "just redraw after the batch" just hides the problem and will make it harder for people to figure out what is wrong
[8:54 PM
] jroweboy: I put the batch fix in bleeding edge because at the time the goal was to compete with the myriad of unofficial builds. The goal post for what bleeding edge is for has changed though. What started as a competitor to unofficial builds turned into a way to crowd test incoming changes. Since that batching hack got rejected again, it looks like it's not going to be in citra proper any time soon
[8:54 PM
] jroweboy: So there's no need for it in canary.
[9:03 PM
] Wes: Thanks for the details. So it sounds like, for those games at least, I'm stuck using the last BE build for many, many moons. That's unfortunate.
[9:11 PM
] jroweboy: sad but likely true. I care way more about the long term health of the project than I care about game playability. If we decide to add a "all hacks here" release, then the new installer supports that, so it wouldn't be hard to add.
[9:13 PM
] jroweboy: To give an idea of what this hack is, the 3ds game submits a batch of commands to the 3ds gpu. One of these commands is a draw command. At this point citra draws what's there as expected. Well some games put more stuff after that without a final draw.
[9:15 PM
] jroweboy: The patch just adds one more draw to the end of a command list. It's unknown what the hardware does. It's possible that one of the other commands does a draw. It's possible that the 3ds always draws at the end of a command list, but no one has tested either assumption. We know a draw is missing, but where?